Close issue on merge #871
Close issue on merge #871
Conversation
Rearrange code to match that of other files. There are no functionality changes introduced in this commit. Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Add an option that allows a user to specify issues that can be closed when the merge request is merged. The --close-issue option can be used multiple times to indicate multiple issues. Signed-off-by: Prarit Bhargava <prarit@redhat.com>
prarit
force-pushed
the
close_issue_on_merge
branch
from
218336c to
971b5b7
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #871 +/- ##
==========================================
+ Coverage 55.25% 55.57% +0.31%
==========================================
Files 82 82
Lines 5961 5988 +27
==========================================
+ Hits 3294 3328 +34
+ Misses 2380 2371 -9
- Partials 287 289 +2
☔ View full report in Codecov by Sentry. |
|
@prarit, the code rearrangement seems odd. Only |
|
@bmeneg I agree, on newly created function we use |
| } | ||
|
|
||
| if len(closeIssues) > 0 { | ||
| closeIssueString := "\n\nCloses " |
There was a problem hiding this comment.
What happens if Closes is in the first line? Does it still work?
This is the Gitlab regex just for reference /^\/(?<cmd>close|reopen|...)(?:( |$))(?<arg>[^\/\n]*)(?:\n|$)/
which if you take all the fuzz, it matches that it is at the start of the line without any break line check.
|
|
||
| func init() { | ||
| mrCreateCmd.Flags().StringArrayP("message", "m", []string{}, "use the given <msg>; multiple -m are concatenated as separate paragraphs") | ||
| mrCreateCmd.Flags().StringSliceP("assignee", "a", []string{}, "set assignee by username; can be specified multiple times for multiple assignees") |
There was a problem hiding this comment.
non-blocking-suggestion: This is true for premium/ultimate, as multiple assignees are not allowed on free plan, so I think we should note that on this description, something like:
| mrCreateCmd.Flags().StringSliceP("assignee", "a", []string{}, "set assignee by username; can be specified multiple times for multiple assignees") | |
| mrCreateCmd.Flags().StringSliceP("assignee", "a", []string{}, "set assignee by username; can be specified multiple times for multiple assignees (multiple assigness is premium gitlab feature)") |
3 participants
close #844